Commit b90e22ba authored Oct 11, 2018 by Lu Fengqi Committed by David Sterba Oct 15, 2018

btrfs: qgroup: move the qgroup->members check out from (!qgroup)'s else branch



There is no reason to put this check in (!qgroup)'s else branch because
if qgroup is null, it will goto out directly. So move it out to reduce
indentation level.  No functional change.

Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 06bbf672

fs/btrfs/qgroup.c

+7 −6

Original line number	Diff line number	Diff line
		@@ -1416,13 +1416,14 @@ int btrfs_remove_qgroup(struct btrfs_trans_handle *trans, u64 qgroupid)
		if (!qgroup) {
		ret = -ENOENT;
		goto out;
		} else {
		/* check if there are no children of this qgroup */
		}

		/* Check if there are no children of this qgroup */
		if (!list_empty(&qgroup->members)) {
		ret = -EBUSY;
		goto out;
		}
		}

		ret = del_qgroup_item(trans, qgroupid);
		if (ret && ret != -ENOENT)
		goto out;