Commit b8f3c361 authored Jul 21, 2020 by Yu Kuai Committed by Greg Kroah-Hartman Aug 19, 2020

MIPS: OCTEON: add missing put_device() call in dwc3_octeon_device_init()



[ Upstream commit e8b9fc10f2615b9a525fce56981e40b489528355 ]

if of_find_device_by_node() succeed, dwc3_octeon_device_init() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.

Fixes: 93e502b3 ("MIPS: OCTEON: Platform support for OCTEON III USB controller")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent db2eabff

arch/mips/cavium-octeon/octeon-usb.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -518,6 +518,7 @@ static int __init dwc3_octeon_device_init(void)

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		if (res == NULL) {
		put_device(&pdev->dev);
		dev_err(&pdev->dev, "No memory resources\n");
		return -ENXIO;
		}
		@@ -529,8 +530,10 @@ static int __init dwc3_octeon_device_init(void)
		* know the difference.
		*/
		base = devm_ioremap_resource(&pdev->dev, res);
		if (IS_ERR(base))
		if (IS_ERR(base)) {
		put_device(&pdev->dev);
		return PTR_ERR(base);
		}

		mutex_lock(&dwc3_octeon_clocks_mutex);
		dwc3_octeon_clocks_start(&pdev->dev, (u64)base);