Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b8d9ee24 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

usb: phy: ab8500: silence some uninitialized variable warnings 



Smatch complains that "reg" can be uninitialized if the
abx500_get_register_interruptible() call fails.  It's an interruptable
function, so we should check if the user presses CTRL-C.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6494a9ad

drivers/usb/phy/phy-ab8500-usb.c

+6 −2
Original line number Diff line number Diff line
@@ -505,15 +505,19 @@ static int abx500_usb_link_status_update(struct ab8500_usb *ab) 
	if (is_ab8500(ab->ab8500)) {

		enum ab8500_usb_link_status lsts;



		abx500_get_register_interruptible(ab->dev,

		ret = abx500_get_register_interruptible(ab->dev,

				AB8500_USB, AB8500_USB_LINE_STAT_REG, &reg);

		if (ret < 0)

			return ret;

		lsts = (reg >> 3) & 0x0F;

		ret = ab8500_usb_link_status_update(ab, lsts);

	} else if (is_ab8505(ab->ab8500)) {

		enum ab8505_usb_link_status lsts;



		abx500_get_register_interruptible(ab->dev,

		ret = abx500_get_register_interruptible(ab->dev,

				AB8500_USB, AB8505_USB_LINE_STAT_REG, &reg);

		if (ret < 0)

			return ret;

		lsts = (reg >> 3) & 0x1F;

		ret = ab8505_usb_link_status_update(ab, lsts);

	}