Commit b8c80606 authored Sep 11, 2021 by Minas Harutyunyan Committed by Greg Kroah-Hartman Sep 30, 2021

usb: dwc2: gadget: Fix ISOC transfer complete handling for DDMA



commit dbe2518b2d8eabffa74dbf7d9fdd7dacddab7fc0 upstream.

When last descriptor in a descriptor list completed with XferComplete
interrupt, core switching to handle next descriptor and assert BNA
interrupt. Both these interrupts are set while dwc2_hsotg_epint()
handler called. Each interrupt should be handled separately: first
XferComplete interrupt then BNA interrupt, otherwise last completed
transfer will not be giveback to function driver as completed
request.

Fixes: 729cac69 ("usb: dwc2: Change ISOC DDMA flow")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
Link: https://lore.kernel.org/r/a36981accc26cd674c5d8f8da6164344b94ec1fe.1631386531.git.Minas.Harutyunyan@synopsys.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ff275c87

drivers/usb/dwc2/gadget.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -3067,8 +3067,6 @@ static void dwc2_hsotg_epint(struct dwc2_hsotg *hsotg, unsigned int idx,

		/* In DDMA handle isochronous requests separately */
		if (using_desc_dma(hsotg) && hs_ep->isochronous) {
		/* XferCompl set along with BNA */
		if (!(ints & DXEPINT_BNAINTR))
		dwc2_gadget_complete_isoc_request_ddma(hs_ep);
		} else if (dir_in) {
		/*