Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b86ac8fd authored by Quinn Tran's avatar Quinn Tran Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Fix process response queue for ISP26XX and above 



This patch improves performance for 16G and above adapter by removing
additional call to process_response_queue().

[mkp: typo]

Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarQuinn Tran <quinn.tran@cavium.com>
Signed-off-by: default avatarHimanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent cca6cb8a

drivers/scsi/qla2xxx/qla_init.c

+0 −2
Original line number Diff line number Diff line
@@ -7142,7 +7142,6 @@ qla24xx_nvram_config(scsi_qla_host_t *vha) 
	}

	icb->firmware_options_2 &= cpu_to_le32(

	    ~(BIT_3 | BIT_2 | BIT_1 | BIT_0));

	vha->flags.process_response_queue = 0;

	if (ha->zio_mode != QLA_ZIO_DISABLED) {

		ha->zio_mode = QLA_ZIO_MODE_6;
@@ -7153,7 +7152,6 @@ qla24xx_nvram_config(scsi_qla_host_t *vha) 
		icb->firmware_options_2 |= cpu_to_le32(

		    (uint32_t)ha->zio_mode);

		icb->interrupt_delay_timer = cpu_to_le16(ha->zio_timer);

		vha->flags.process_response_queue = 1;

	}



	if (rval) {

drivers/scsi/qla2xxx/qla_iocb.c

+0 −17
Original line number Diff line number Diff line
@@ -1526,12 +1526,6 @@ qla24xx_start_scsi(srb_t *sp) 


	/* Set chip new ring index. */

	WRT_REG_DWORD(req->req_q_in, req->ring_index);

	RD_REG_DWORD_RELAXED(&ha->iobase->isp24.hccr);



	/* Manage unprocessed RIO/ZIO commands in response queue. */

	if (vha->flags.process_response_queue &&

		rsp->ring_ptr->signature != RESPONSE_PROCESSED)

		qla24xx_process_response_queue(vha, rsp);



	spin_unlock_irqrestore(&ha->hardware_lock, flags);

	return QLA_SUCCESS;
@@ -1725,12 +1719,6 @@ qla24xx_dif_start_scsi(srb_t *sp) 


	/* Set chip new ring index. */

	WRT_REG_DWORD(req->req_q_in, req->ring_index);

	RD_REG_DWORD_RELAXED(&ha->iobase->isp24.hccr);



	/* Manage unprocessed RIO/ZIO commands in response queue. */

	if (vha->flags.process_response_queue &&

	    rsp->ring_ptr->signature != RESPONSE_PROCESSED)

		qla24xx_process_response_queue(vha, rsp);



	spin_unlock_irqrestore(&ha->hardware_lock, flags);
@@ -1880,11 +1868,6 @@ qla2xxx_start_scsi_mq(srb_t *sp) 
	/* Set chip new ring index. */

	WRT_REG_DWORD(req->req_q_in, req->ring_index);



	/* Manage unprocessed RIO/ZIO commands in response queue. */

	if (vha->flags.process_response_queue &&

		rsp->ring_ptr->signature != RESPONSE_PROCESSED)

		qla24xx_process_response_queue(vha, rsp);



	spin_unlock_irqrestore(&qpair->qp_lock, flags);

	return QLA_SUCCESS;