Commit b869901c authored Aug 13, 2021 by Jiapeng Chong Committed by Greg Kroah-Hartman Sep 30, 2021

fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()



[ Upstream commit a1e4470823d99e75b596748086e120dea169ed3c ]

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.

Eliminate the follow smatch warning:

drivers/fpga/machxo2-spi.c:341 machxo2_write_complete()
  warn: missing error code 'ret'.

[mdf@kernel.org: Reworded commit message]
Fixes: 88fb3a00 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 0ebc3e68

drivers/fpga/machxo2-spi.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -334,6 +334,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr,
		break;
		if (++refreshloop == MACHXO2_MAX_REFRESH_LOOP) {
		machxo2_cleanup(mgr);
		ret = -EINVAL;
		goto fail;
		}
		} while (1);