Commit b85f87d3 authored Dec 26, 2021 by Christophe JAILLET Committed by Greg Kroah-Hartman Jan 05, 2022

ionic: Initialize the 'lif->dbid_inuse' bitmap



[ Upstream commit 140c7bc7d1195750342ea0e6ab76179499ae7cd7 ]

When allocated, this bitmap is not initialized. Only the first bit is set a
few lines below.

Use bitmap_zalloc() to make sure that it is cleared before being used.

Fixes: 6461b446 ("ionic: Add interrupts and doorbells")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Link: https://lore.kernel.org/r/6a478eae0b5e6c63774e1f0ddb1a3f8c38fa8ade.1640527506.git.christophe.jaillet@wanadoo.fr


Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1cd4063d

drivers/net/ethernet/pensando/ionic/ionic_lif.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1995,7 +1995,7 @@ static int ionic_lif_init(struct ionic_lif *lif)
		return -EINVAL;
		}

		lif->dbid_inuse = bitmap_alloc(lif->dbid_count, GFP_KERNEL);
		lif->dbid_inuse = bitmap_zalloc(lif->dbid_count, GFP_KERNEL);
		if (!lif->dbid_inuse) {
		dev_err(dev, "Failed alloc doorbell id bitmap, aborting\n");
		return -ENOMEM;