Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b7f5b656 authored by Raag Jadav's avatar Raag Jadav Committed by Vinod Koul
Browse files

dmaengine: at_xdmac: check for non-empty xfers_list before invoking callback 



tx descriptor retrieved from an empty xfers_list may not have valid
pointers to the callback functions.
Avoid calling dmaengine_desc_get_callback_invoke if xfers_list is empty.

Signed-off-by: default avatarRaag Jadav <raagjadav@gmail.com>
Acked-by: default avatarLudovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 9dcb98a2

drivers/dma/at_xdmac.c

+7 −4
Original line number Diff line number Diff line
@@ -1579,12 +1579,15 @@ static void at_xdmac_handle_cyclic(struct at_xdmac_chan *atchan) 
	struct at_xdmac_desc		*desc;

	struct dma_async_tx_descriptor	*txd;



	desc = list_first_entry(&atchan->xfers_list, struct at_xdmac_desc, xfer_node);

	if (!list_empty(&atchan->xfers_list)) {

		desc = list_first_entry(&atchan->xfers_list,

					struct at_xdmac_desc, xfer_node);

		txd = &desc->tx_dma_desc;



		if (txd->flags & DMA_PREP_INTERRUPT)

			dmaengine_desc_get_callback_invoke(txd, NULL);

	}

}



static void at_xdmac_handle_error(struct at_xdmac_chan *atchan)

{