Commit b7e5563f authored Jul 09, 2021 by Pavel Skripkin Committed by Greg Kroah-Hartman Jul 25, 2021

net: ti: fix UAF in tlan_remove_one



commit 0336f8ffece62f882ab3012820965a786a983f70 upstream.

priv is netdev private data and it cannot be
used after free_netdev() call. Using priv after free_netdev()
can cause UAF bug. Fix it by moving free_netdev() at the end of the
function.

Fixes: 1e0a8b13 ("tlan: cancel work at remove path")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2b70ca92

drivers/net/ethernet/ti/tlan.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -314,9 +314,8 @@ static void tlan_remove_one(struct pci_dev *pdev)
		pci_release_regions(pdev);
		#endif

		free_netdev(dev);

		cancel_work_sync(&priv->tlan_tqueue);
		free_netdev(dev);
		}

		static void tlan_start(struct net_device *dev)