Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b774fcef authored by Andrey Smirnov's avatar Andrey Smirnov Committed by Wim Van Sebroeck
Browse files

watchdog: ziirave_wdt: Be more verbose during firmware update 



Add more error logging to ziirave_firm_upload() for diagnostics.

Signed-off-by: default avatarAndrey Smirnov <andrew.smirnov@gmail.com>
Cc: Chris Healy <cphealy@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Rick Ramstetter <rick@anteaterllc.com>
Cc: linux-watchdog@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20190812200906.31344-4-andrew.smirnov@gmail.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent 4a9600c7

drivers/watchdog/ziirave_wdt.c

+14 −4
Original line number Diff line number Diff line
@@ -335,14 +335,18 @@ static int ziirave_firm_upload(struct watchdog_device *wdd, 


	ret = ziirave_firm_write_byte(wdd, ZIIRAVE_CMD_JUMP_TO_BOOTLOADER, 1,

				      false);

	if (ret)

	if (ret) {

		dev_err(&client->dev, "Failed to jump to bootloader\n");

		return ret;

	}



	msleep(500);



	ret = ziirave_firm_write_byte(wdd, ZIIRAVE_CMD_DOWNLOAD_START, 1, true);

	if (ret)

	if (ret) {

		dev_err(&client->dev, "Failed to start download\n");

		return ret;

	}



	msleep(500);
@@ -438,14 +442,20 @@ static int ziirave_firm_upload(struct watchdog_device *wdd, 


	/* End download operation */

	ret = ziirave_firm_write_byte(wdd, ZIIRAVE_CMD_DOWNLOAD_END, 1, false);

	if (ret)

	if (ret) {

		dev_err(&client->dev,

			"Failed to end firmware download: %d\n", ret);

		return ret;

	}



	/* Reset the processor */

	ret = ziirave_firm_write_byte(wdd, ZIIRAVE_CMD_RESET_PROCESSOR, 1,

				      false);

	if (ret)

	if (ret) {

		dev_err(&client->dev,

			"Failed to reset the watchdog: %d\n", ret);

		return ret;

	}



	msleep(500);