Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b76f7cdc authored by Marek Szyprowski's avatar Marek Szyprowski Committed by Kukjin Kim
Browse files

ARM: S5P: fix incorrect loop iterator usage on gpio-interrupt 



Loop iterator value after terminating list_for_each_entry()
is not NULL. This patch fixes incorrect iterator usage in
GPIO interrupt code for SAMSUNG S5P platforms.

Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: default avatarKyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: default avatarKukjin Kim <kgene.kim@samsung.com>
parent 4344646f

arch/arm/plat-s5p/irq-gpioint.c

+5 −4
Original line number Diff line number Diff line
@@ -114,18 +114,19 @@ static __init int s5p_gpioint_add(struct s3c_gpio_chip *chip) 
{

	static int used_gpioint_groups = 0;

	int group = chip->group;

	struct s5p_gpioint_bank *bank = NULL;

	struct s5p_gpioint_bank *b, *bank = NULL;

	struct irq_chip_generic *gc;

	struct irq_chip_type *ct;



	if (used_gpioint_groups >= S5P_GPIOINT_GROUP_COUNT)

		return -ENOMEM;



	list_for_each_entry(bank, &banks, list) {

		if (group >= bank->start &&

		    group < bank->start + bank->nr_groups)

	list_for_each_entry(b, &banks, list) {

		if (group >= b->start && group < b->start + b->nr_groups) {

			bank = b;

			break;

		}

	}

	if (!bank)

		return -EINVAL;