Commit b76dcf46 authored Nov 21, 2023 by Pablo Neira Ayuso Committed by Greg Kroah-Hartman Nov 28, 2023

netfilter: nf_tables: GC transaction race with netns dismantle

commit 02c6c24402bf1c1e986899c14ba22a10b510916b upstream.

Use maybe_get_net() since GC workqueue might race with netns exit path.

Fixes: 5f68718b34a5 ("netfilter: nf_tables: GC transaction API to avoid race with control plane")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 29ff9b8e

net/netfilter/nf_tables_api.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -7052,9 +7052,14 @@ struct nft_trans_gc nft_trans_gc_alloc(struct nft_set set,
		if (!trans)
		return NULL;

		trans->net = maybe_get_net(net);
		if (!trans->net) {
		kfree(trans);
		return NULL;
		}

		refcount_inc(&set->refs);
		trans->set = set;
		trans->net = get_net(net);
		trans->seq = gc_seq;

		return trans;