Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b72b13eb authored by Jeff Layton's avatar Jeff Layton Committed by Ilya Dryomov
Browse files

ceph: don't SetPageError on writepage errors 



We already mark the mapping in that case, and doing this can cause
false positives to occur at fsync time, as well as spurious read
errors.

Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent 131d7eb4

fs/ceph/addr.c

+1 −2
Original line number Diff line number Diff line
@@ -573,7 +573,7 @@ static u64 get_writepages_data_length(struct inode *inode, 
/*

 * Write a single page, but leave the page locked.

 *

 * If we get a write error, set the page error bit, but still adjust the

 * If we get a write error, mark the mapping for error, but still adjust the

 * dirty page accounting (i.e., page is no longer dirty).

 */

static int writepage_nounlock(struct page *page, struct writeback_control *wbc)
@@ -648,7 +648,6 @@ static int writepage_nounlock(struct page *page, struct writeback_control *wbc) 
			fsc->blacklisted = true;

		dout("writepage setting page/mapping error %d %p\n",

		     err, page);

		SetPageError(page);

		mapping_set_error(&inode->i_data, err);

		wbc->pages_skipped++;

	} else {