Commit b6d4e16e authored Jun 09, 2016 by Felipe Balbi

usb: dwc3: gadget: simplify run_stop() break condition



it's clear now that when is_on=true, we must loop
until DWC3_DSTS_DEVCTRLHLT clears; while when
is_on=false we must loop until DWC3_DSTS_DEVCTRLHLT
gets set.

Instead of adding actual if() statements, we can
rely on XOR operation to evaluate to true only when
the above conditions apply. Then, we can move the
break condition back to the while() statement
together with our timeout check and the resulting
code is very compact and simpler to read.

Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent f2df679b

drivers/usb/dwc3/gadget.c

+2 −8

Original line number	Diff line number	Diff line
		@@ -1574,14 +1574,8 @@ static int dwc3_gadget_run_stop(struct dwc3 *dwc, int is_on, int suspend)

		do {
		reg = dwc3_readl(dwc->regs, DWC3_DSTS);
		if (is_on) {
		if (!(reg & DWC3_DSTS_DEVCTRLHLT))
		break;
		} else {
		if (reg & DWC3_DSTS_DEVCTRLHLT)
		break;
		}
		} while (--timeout);
		reg &= DWC3_DSTS_DEVCTRLHLT;
		} while (--timeout && !(!is_on ^ !reg));

		if (!timeout)
		return -ETIMEDOUT;