Commit b5f03484 authored Jan 08, 2019 by Linus Walleij Committed by Gregory CLEMENT Jan 10, 2019

ARM: dts: kirkwood: Fix polarity of GPIO fan lines



These two lines are active high, not active low. The bug was
found when we changed the kernel to respect the polarity defined
in the device tree.

Fixes: 1b90e06b ("ARM: kirkwood: Use devicetree to define DNS-32[05] fan")
Cc: Jamie Lentin <jm@lentin.co.uk>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Gregory Clement <gregory.clement@bootlin.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Julien D'Ascenzio <jdascenzio@posteo.net>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Jamie Lentin <jm@lentin.co.uk>
Reported-by: Julien D'Ascenzio <jdascenzio@posteo.net>
Tested-by: Julien D'Ascenzio <jdascenzio@posteo.net>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>

parent 59c4dccb

arch/arm/boot/dts/kirkwood-dnskw.dtsi

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -36,8 +36,8 @@
	compatible = "gpio-fan";		compatible = "gpio-fan";
	pinctrl-0 = <&pmx_fan_high_speed &pmx_fan_low_speed>;		pinctrl-0 = <&pmx_fan_high_speed &pmx_fan_low_speed>;
	pinctrl-names = "default";		pinctrl-names = "default";
	gpios = <&gpio1 14 GPIO_ACTIVE_LOW		gpios = <&gpio1 14 GPIO_ACTIVE_HIGH
	&gpio1 13 GPIO_ACTIVE_LOW>;		&gpio1 13 GPIO_ACTIVE_HIGH>;
	gpio-fan,speed-map = <0 0		gpio-fan,speed-map = <0 0
	3000 1		3000 1
	6000 2>;		6000 2>;