Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b5c3bc4b authored by Trond Myklebust's avatar Trond Myklebust Committed by Greg Kroah-Hartman
Browse files

NFS: Fix a race in __nfs_list_for_each_server() 



commit 9c07b75b80eeff714420fb6a4c880b284e529d0f upstream.

The struct nfs_server gets put on the cl_superblocks list before
the server->super field has been initialised, in which case the
call to nfs_sb_active() will Oops. Add a check to ensure that
we skip such a list entry.

Fixes: 3c9e502b59fb ("NFS: Add a helper nfs_client_for_each_server()")
Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f0ea421f

fs/nfs/super.c

+1 −1
Original line number Diff line number Diff line
@@ -445,7 +445,7 @@ static int __nfs_list_for_each_server(struct list_head *head, 


	rcu_read_lock();

	list_for_each_entry_rcu(server, head, client_link) {

		if (!nfs_sb_active(server->super))

		if (!(server->super && nfs_sb_active(server->super)))

			continue;

		rcu_read_unlock();

		if (last)