Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b54bac97 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Greg Kroah-Hartman
Browse files

memory: brcmstb_dpfe: fix testing array offset after use 



[ Upstream commit 1d9e93fad549bc38f593147479ee063f2872c170 ]

Code should first check for valid value of array offset, then use it as
the index.  Fixes smatch warning:

  drivers/memory/brcmstb_dpfe.c:443 __send_command() error: testing array offset 'cmd' after use.

Fixes: 2f330caf ("memory: brcmstb: Add driver for DPFE")
Acked-by: default avatarMarkus Mayer <mmayer@broadcom.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20230513112931.176066-1-krzysztof.kozlowski@linaro.org


Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent f54142ed

drivers/memory/brcmstb_dpfe.c

+3 −1
Original line number Diff line number Diff line
@@ -398,15 +398,17 @@ static void __finalize_command(struct private_data *priv) 
static int __send_command(struct private_data *priv, unsigned int cmd,

			  u32 result[])

{

	const u32 *msg = priv->dpfe_api->command[cmd];

	void __iomem *regs = priv->regs;

	unsigned int i, chksum, chksum_idx;

	const u32 *msg;

	int ret = 0;

	u32 resp;



	if (cmd >= DPFE_CMD_MAX)

		return -1;



	msg = priv->dpfe_api->command[cmd];



	mutex_lock(&priv->lock);



	/* Wait for DCPU to become ready */