Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b4e4f47e authored by Wei Yongjun's avatar Wei Yongjun Committed by Johannes Berg
Browse files

nl80211: fix possible memory leak nl80211_connect() 

connkeys is malloced in nl80211_parse_connkeys() and should
be freed in the error handling case, otherwise it will cause
memory leak.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/

)

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 3d2abdfd

net/wireless/nl80211.c

+3 −1
Original line number Diff line number Diff line
@@ -5633,8 +5633,10 @@ static int nl80211_connect(struct sk_buff *skb, struct genl_info *info) 
		       sizeof(connect.ht_capa_mask));



	if (info->attrs[NL80211_ATTR_HT_CAPABILITY]) {

		if (!info->attrs[NL80211_ATTR_HT_CAPABILITY_MASK])

		if (!info->attrs[NL80211_ATTR_HT_CAPABILITY_MASK]) {

			kfree(connkeys);

			return -EINVAL;

		}

		memcpy(&connect.ht_capa,

		       nla_data(info->attrs[NL80211_ATTR_HT_CAPABILITY]),

		       sizeof(connect.ht_capa));