Commit b4e30e8e authored Apr 25, 2019 by Michael Chan Committed by David S. Miller Apr 27, 2019

bnxt_en: Improve multicast address setup logic.



The driver builds a list of multicast addresses and sends it to the
firmware when the driver's ndo_set_rx_mode() is called.  In rare
cases, the firmware can fail this call if internal resources to
add multicast addresses are exhausted.  In that case, we should
try the call again by setting the ALL_MCAST flag which is more
guaranteed to succeed.

Fixes: c0c050c5 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent fdfdf867

drivers/net/ethernet/broadcom/bnxt/bnxt.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -8961,8 +8961,15 @@ static int bnxt_cfg_rx_mode(struct bnxt *bp)

		skip_uc:
		rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, 0);
		if (rc && vnic->mc_list_count) {
		netdev_info(bp->dev, "Failed setting MC filters rc: %d, turning on ALL_MCAST mode\n",
		rc);
		vnic->rx_mask \|= CFA_L2_SET_RX_MASK_REQ_MASK_ALL_MCAST;
		vnic->mc_list_count = 0;
		rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, 0);
		}
		if (rc)
		netdev_err(bp->dev, "HWRM cfa l2 rx mask failure rc: %x\n",
		netdev_err(bp->dev, "HWRM cfa l2 rx mask failure rc: %d\n",
		rc);

		return rc;