Commit b4c798cf authored Aug 10, 2012 by Xue Ying Committed by David Teigland Aug 10, 2012

dlm: remove redundant variable assignments



Once the tcp_create_listen_sock() is returned successfully, we
will invoke add_sock() immediately. In add_sock(), the 'con'
variable is assigned to 'sk_user_data', meanwhile, the 'sock' is
also set to 'con->sock'. So it's unnecessary to do the same thing
in tcp_create_listen_sock().

Signed-off-by: Xue Ying <ying.xue@windriver.com>
Signed-off-by: David Teigland <teigland@redhat.com>

parent 475f230c

fs/dlm/lowcomms.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1175,10 +1175,8 @@ static struct socket tcp_create_listen_sock(struct connection con,
		if (result < 0) {
		log_print("Failed to set SO_REUSEADDR on socket: %d", result);
		}
		sock->sk->sk_user_data = con;
		con->rx_action = tcp_accept_from_sock;
		con->connect_action = tcp_connect_to_sock;
		con->sock = sock;

		/* Bind to our port */
		make_sockaddr(saddr, dlm_config.ci_tcp_port, &addr_len);