Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b47ae6f8 authored by Mark Zhang's avatar Mark Zhang Committed by Jason Gunthorpe
Browse files

RDMA/nldev: Allow counter auto mode configration through RDMA netlink 



Provide an option to enable/disable per-port counter auto mode through
RDMA netlink. Limit it to users with ADMIN capability only.

Signed-off-by: default avatarMark Zhang <markz@mellanox.com>
Reviewed-by: default avatarMajd Dibbiny <majd@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 45842fc6

drivers/infiniband/core/nldev.c

+78 −0
Original line number Diff line number Diff line
@@ -126,6 +126,9 @@ static const struct nla_policy nldev_policy[RDMA_NLDEV_ATTR_MAX] = { 
	[RDMA_NLDEV_ATTR_RES_USECNT]		= { .type = NLA_U64 },

	[RDMA_NLDEV_ATTR_SM_LID]		= { .type = NLA_U32 },

	[RDMA_NLDEV_ATTR_SUBNET_PREFIX]		= { .type = NLA_U64 },

	[RDMA_NLDEV_ATTR_STAT_AUTO_MODE_MASK]	= { .type = NLA_U32 },

	[RDMA_NLDEV_ATTR_STAT_MODE]		= { .type = NLA_U32 },

	[RDMA_NLDEV_ATTR_STAT_RES]		= { .type = NLA_U32 },

	[RDMA_NLDEV_ATTR_SYS_IMAGE_GUID]	= { .type = NLA_U64 },

	[RDMA_NLDEV_ATTR_UVERBS_DRIVER_ID]	= { .type = NLA_U32 },

	[RDMA_NLDEV_NET_NS_FD]			= { .type = NLA_U32 },
@@ -1482,6 +1485,78 @@ static int nldev_set_sys_set_doit(struct sk_buff *skb, struct nlmsghdr *nlh, 
	return err;

}



static int nldev_stat_set_doit(struct sk_buff *skb, struct nlmsghdr *nlh,

			       struct netlink_ext_ack *extack)

{

	struct nlattr *tb[RDMA_NLDEV_ATTR_MAX];

	u32 index, port, mode, mask = 0;

	struct ib_device *device;

	struct sk_buff *msg;

	int ret;



	ret = nlmsg_parse(nlh, 0, tb, RDMA_NLDEV_ATTR_MAX - 1,

			  nldev_policy, extack);

	/* Currently only counter for QP is supported */

	if (ret || !tb[RDMA_NLDEV_ATTR_STAT_RES] ||

	    !tb[RDMA_NLDEV_ATTR_DEV_INDEX] ||

	    !tb[RDMA_NLDEV_ATTR_PORT_INDEX] || !tb[RDMA_NLDEV_ATTR_STAT_MODE])

		return -EINVAL;



	if (nla_get_u32(tb[RDMA_NLDEV_ATTR_STAT_RES]) != RDMA_NLDEV_ATTR_RES_QP)

		return -EINVAL;



	index = nla_get_u32(tb[RDMA_NLDEV_ATTR_DEV_INDEX]);

	device = ib_device_get_by_index(sock_net(skb->sk), index);

	if (!device)

		return -EINVAL;



	port = nla_get_u32(tb[RDMA_NLDEV_ATTR_PORT_INDEX]);

	if (!rdma_is_port_valid(device, port)) {

		ret = -EINVAL;

		goto err;

	}



	msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);

	if (!msg) {

		ret = -ENOMEM;

		goto err;

	}

	nlh = nlmsg_put(msg, NETLINK_CB(skb).portid, nlh->nlmsg_seq,

			RDMA_NL_GET_TYPE(RDMA_NL_NLDEV,

					 RDMA_NLDEV_CMD_STAT_SET),

			0, 0);



	mode = nla_get_u32(tb[RDMA_NLDEV_ATTR_STAT_MODE]);

	if (mode != RDMA_COUNTER_MODE_AUTO) {

		ret = -EMSGSIZE;

		goto err_msg;

	}



	if (tb[RDMA_NLDEV_ATTR_STAT_AUTO_MODE_MASK])

		mask = nla_get_u32(tb[RDMA_NLDEV_ATTR_STAT_AUTO_MODE_MASK]);



	ret = rdma_counter_set_auto_mode(device, port,

					 mask ? true : false, mask);

	if (ret)

		goto err_msg;



	if (nla_put_u32(msg, RDMA_NLDEV_ATTR_STAT_MODE, mode) ||

	    nla_put_u32(msg, RDMA_NLDEV_ATTR_STAT_AUTO_MODE_MASK, mask)) {

		ret = -EMSGSIZE;

		goto err_msg;

	}



	nlmsg_end(msg, nlh);

	ib_device_put(device);

	return rdma_nl_unicast(msg, NETLINK_CB(skb).portid);



err_msg:

	nlmsg_free(msg);

err:

	ib_device_put(device);

	return ret;

}



static const struct rdma_nl_cbs nldev_cb_table[RDMA_NLDEV_NUM_OPS] = {

	[RDMA_NLDEV_CMD_GET] = {

		.doit = nldev_get_doit,
@@ -1535,6 +1610,9 @@ static const struct rdma_nl_cbs nldev_cb_table[RDMA_NLDEV_NUM_OPS] = { 
	},

	[RDMA_NLDEV_CMD_SYS_SET] = {

		.doit = nldev_set_sys_set_doit,

	},

	[RDMA_NLDEV_CMD_STAT_SET] = {

		.doit = nldev_stat_set_doit,

		.flags = RDMA_NL_ADMIN_PERM,

	},

};

include/uapi/rdma/rdma_netlink.h

+8 −0
Original line number Diff line number Diff line
@@ -281,6 +281,8 @@ enum rdma_nldev_command { 


	RDMA_NLDEV_CMD_GET_CHARDEV,



	RDMA_NLDEV_CMD_STAT_SET,



	RDMA_NLDEV_NUM_OPS

};
@@ -488,6 +490,12 @@ enum rdma_nldev_attr { 
	 * File descriptor handle of the net namespace object

	 */

	RDMA_NLDEV_NET_NS_FD,			/* u32 */

	/*

	 * Counter-specific attributes.

	 */

	RDMA_NLDEV_ATTR_STAT_MODE,		/* u32 */

	RDMA_NLDEV_ATTR_STAT_RES,		/* u32 */

	RDMA_NLDEV_ATTR_STAT_AUTO_MODE_MASK,	/* u32 */



	/*

	 * Information about a chardev.