Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b43d6c8e authored by Ping-Ke Shih's avatar Ping-Ke Shih Committed by Kalle Valo
Browse files

rtlwifi: remove assignment to itself 



Module parameters of 'sw_crypto' and 'disable_watchdog' are false by
default. If new value is desired, we can do it during inserting module,
assignment existing in source code is not reasonable.

Reported-by: default avatarDavid Binderman <dcb314@hotmail.com>
CC: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarPing-Ke Shih <pkshih@realtek.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent e3b1d879

drivers/net/wireless/realtek/rtlwifi/rtl8188ee/sw.c

+0 −4
Original line number Diff line number Diff line
@@ -115,10 +115,6 @@ int rtl88e_init_sw_vars(struct ieee80211_hw *hw) 
	rtlpriv->psc.swctrl_lps = rtlpriv->cfg->mod_params->swctrl_lps;

	rtlpriv->psc.fwctrl_lps = rtlpriv->cfg->mod_params->fwctrl_lps;

	rtlpci->msi_support = rtlpriv->cfg->mod_params->msi_support;

	rtlpriv->cfg->mod_params->sw_crypto =

		rtlpriv->cfg->mod_params->sw_crypto;

	rtlpriv->cfg->mod_params->disable_watchdog =

		rtlpriv->cfg->mod_params->disable_watchdog;

	if (rtlpriv->cfg->mod_params->disable_watchdog)

		pr_info("watchdog disabled\n");

	if (!rtlpriv->psc.inactiveps)

drivers/net/wireless/realtek/rtlwifi/rtl8192ce/sw.c

+0 −2
Original line number Diff line number Diff line
@@ -113,8 +113,6 @@ int rtl92c_init_sw_vars(struct ieee80211_hw *hw) 
	rtlpriv->psc.inactiveps = rtlpriv->cfg->mod_params->inactiveps;

	rtlpriv->psc.swctrl_lps = rtlpriv->cfg->mod_params->swctrl_lps;

	rtlpriv->psc.fwctrl_lps = rtlpriv->cfg->mod_params->fwctrl_lps;

	rtlpriv->cfg->mod_params->sw_crypto =

		rtlpriv->cfg->mod_params->sw_crypto;

	if (!rtlpriv->psc.inactiveps)

		pr_info("rtl8192ce: Power Save off (module option)\n");

	if (!rtlpriv->psc.fwctrl_lps)

drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c

+0 −2
Original line number Diff line number Diff line
@@ -39,8 +39,6 @@ static int rtl92cu_init_sw_vars(struct ieee80211_hw *hw) 
	rtlpriv->dm.dm_flag = 0;

	rtlpriv->dm.disable_framebursting = false;

	rtlpriv->dm.thermalvalue = 0;

	rtlpriv->cfg->mod_params->sw_crypto =

		rtlpriv->cfg->mod_params->sw_crypto;



	/* for firmware buf */

	rtlpriv->rtlhal.pfirmware = vzalloc(0x4000);

drivers/net/wireless/realtek/rtlwifi/rtl8192se/sw.c

+0 −2
Original line number Diff line number Diff line
@@ -161,8 +161,6 @@ static int rtl92s_init_sw_vars(struct ieee80211_hw *hw) 
	rtlpriv->psc.inactiveps = rtlpriv->cfg->mod_params->inactiveps;

	rtlpriv->psc.swctrl_lps = rtlpriv->cfg->mod_params->swctrl_lps;

	rtlpriv->psc.fwctrl_lps = rtlpriv->cfg->mod_params->fwctrl_lps;

	rtlpriv->cfg->mod_params->sw_crypto =

		rtlpriv->cfg->mod_params->sw_crypto;

	if (!rtlpriv->psc.inactiveps)

		pr_info("Power Save off (module option)\n");

	if (!rtlpriv->psc.fwctrl_lps)

drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c

+0 −4
Original line number Diff line number Diff line
@@ -129,10 +129,6 @@ int rtl8723e_init_sw_vars(struct ieee80211_hw *hw) 
	rtlpriv->psc.swctrl_lps = rtlpriv->cfg->mod_params->swctrl_lps;

	rtlpriv->psc.fwctrl_lps = rtlpriv->cfg->mod_params->fwctrl_lps;

	rtlpci->msi_support = rtlpriv->cfg->mod_params->msi_support;

	rtlpriv->cfg->mod_params->sw_crypto =

		rtlpriv->cfg->mod_params->sw_crypto;

	rtlpriv->cfg->mod_params->disable_watchdog =

		rtlpriv->cfg->mod_params->disable_watchdog;

	if (rtlpriv->cfg->mod_params->disable_watchdog)

		pr_info("watchdog disabled\n");

	rtlpriv->psc.reg_fwctrl_lps = 3;