Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b425b020 authored by Sachin Shukla's avatar Sachin Shukla Committed by Jens Axboe
Browse files

Block: mtip32xx: Improvement in code readability when memdup_user() fails. 



There is no need to call kfree() if memdup_user() fails, as no memory
was allocated and the error in the error-valued pointer should be returned.

Signed-off-by: default avatarSachin Shukla <sachin.s5@samsung.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 066a4a73

drivers/block/mtip32xx/mtip32xx.c

+5 −9
Original line number Diff line number Diff line
@@ -2035,18 +2035,14 @@ static int exec_drive_taskfile(struct driver_data *dd, 
	taskout = req_task->out_size;

	taskin = req_task->in_size;

	/* 130560 = 512 * 0xFF*/

	if (taskin > 130560 || taskout > 130560) {

		err = -EINVAL;

		goto abort;

	}

	if (taskin > 130560 || taskout > 130560)

		return -EINVAL;



	if (taskout) {

		outbuf = memdup_user(buf + outtotal, taskout);

		if (IS_ERR(outbuf)) {

			err = PTR_ERR(outbuf);

			outbuf = NULL;

			goto abort;

		}

		if (IS_ERR(outbuf))

			return PTR_ERR(outbuf);



		outbuf_dma = pci_map_single(dd->pdev,

					 outbuf,

					 taskout,