Commit b3e3d584 authored Dec 30, 2021 by Miaoqian Lin Committed by Greg Kroah-Hartman Feb 01, 2022

drm/msm/dsi: Fix missing put_device() call in dsi_get_phy



commit c04c3148ca12227d92f91b355b4538cc333c9922 upstream.

If of_find_device_by_node() succeeds, dsi_get_phy() doesn't
a corresponding put_device(). Thus add put_device() to fix the exception
handling.

Fixes: ec31abf6 ("drm/msm/dsi: Separate PHY to another platform device")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20211230070943.18116-1-linmq006@gmail.com


Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4abd2a77

drivers/gpu/drm/msm/dsi/dsi.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -33,7 +33,12 @@ static int dsi_get_phy(struct msm_dsi *msm_dsi)

		of_node_put(phy_node);

		if (!phy_pdev \|\| !msm_dsi->phy) {
		if (!phy_pdev) {
		DRM_DEV_ERROR(&pdev->dev, "%s: phy driver is not ready\n", __func__);
		return -EPROBE_DEFER;
		}
		if (!msm_dsi->phy) {
		put_device(&phy_pdev->dev);
		DRM_DEV_ERROR(&pdev->dev, "%s: phy driver is not ready\n", __func__);
		return -EPROBE_DEFER;
		}