Commit b3ccefae authored Feb 12, 2018 by Josh Poimboeuf Committed by Ingo Molnar Feb 13, 2018

x86/entry/64: Fix paranoid_entry() frame pointer warning



With the following commit:

  f09d160992d1 ("x86/entry/64: Get rid of the ALLOC_PT_GPREGS_ON_STACK and SAVE_AND_CLEAR_REGS macros")

... one of my suggested improvements triggered a frame pointer warning:

  arch/x86/entry/entry_64.o: warning: objtool: paranoid_entry()+0x11: call without frame pointer save/setup

The warning is correct for the build-time code, but it's actually not
relevant at runtime because of paravirt patching.  The paravirt swapgs
call gets replaced with either a SWAPGS instruction or NOPs at runtime.

Go back to the previous behavior by removing the ELF function annotation
for paranoid_entry() and adding an unwind hint, which effectively
silences the warning.

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kbuild-all@01.org
Cc: tipbuild@zytor.com
Fixes: f09d160992d1 ("x86/entry/64: Get rid of the ALLOC_PT_GPREGS_ON_STACK and SAVE_AND_CLEAR_REGS macros")
Link: http://lkml.kernel.org/r/20180212174503.5acbymg5z6p32snu@treble


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 92816f57

arch/x86/entry/entry_64.S

+2 −1

Original line number	Diff line number	Diff line
		@@ -1128,6 +1128,7 @@ idtentry machine_check do_mce has_error_code=0 paranoid=1
		* Return: ebx=0: need swapgs on exit, ebx=1: otherwise
		*/
		ENTRY(paranoid_entry)
		UNWIND_HINT_FUNC
		cld
		movl $1, %ebx
		movl $MSR_GS_BASE, %ecx
		@@ -1141,7 +1142,7 @@ ENTRY(paranoid_entry)
		SAVE_AND_SWITCH_TO_KERNEL_CR3 scratch_reg=%rax save_reg=%r14

		ret
		ENDPROC(paranoid_entry)
		END(paranoid_entry)

		/*
		* "Paranoid" exit path from exception stack. This is invoked