Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b348618c authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

pinctrl: mediatek: Fix missing of_node_put() in mtk_pctrl_init 



[ Upstream commit dab4df9ca919f59e5b9dd84385eaf34d4f20dbb0 ]

The device_node pointer is returned by of_parse_phandle()  with refcount
incremented. We should use of_node_put() on it when done.

Fixes: a6df410d ("pinctrl: mediatek: Add Pinctrl/GPIO driver for mt8135.")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220308071155.21114-1-linmq006@gmail.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 6e0d6961

drivers/pinctrl/mediatek/pinctrl-mtk-common.c

+2 −0
Original line number Diff line number Diff line
@@ -1038,6 +1038,7 @@ int mtk_pctrl_init(struct platform_device *pdev, 
	node = of_parse_phandle(np, "mediatek,pctl-regmap", 0);

	if (node) {

		pctl->regmap1 = syscon_node_to_regmap(node);

		of_node_put(node);

		if (IS_ERR(pctl->regmap1))

			return PTR_ERR(pctl->regmap1);

	} else if (regmap) {
@@ -1051,6 +1052,7 @@ int mtk_pctrl_init(struct platform_device *pdev, 
	node = of_parse_phandle(np, "mediatek,pctl-regmap", 1);

	if (node) {

		pctl->regmap2 = syscon_node_to_regmap(node);

		of_node_put(node);

		if (IS_ERR(pctl->regmap2))

			return PTR_ERR(pctl->regmap2);

	}