Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b339da48 authored by Ingo Molnar's avatar Ingo Molnar
Browse files

Merge tag 'perf-core-for-mingo-5.1-20190307' of... 

Merge tag 'perf-core-for-mingo-5.1-20190307' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux

 into perf/urgent

Pull perf/core changes from Arnaldo Carvalho de Melo:

perf bpf:

  Arnaldo Carvalho de Melo:

  - Automatically add BTF ELF markers to 'perf trace' BPF programs, so that
    tools such as 'bpftool map dump' can pretty print map keys and values.

perf c2c:

  Jiri Olsa:

  - Fix report for empty NUMA node.

perf diff:

  Jin Yao:

  - Support --time, --cpu, --pid and --tid filter options.

perf probe:

  Arnaldo Carvalho de Melo:

  - Clarify error message about not finding kernel modules debuginfo.

perf record:

  Jiri Olsa:

  - Fixup probing for max attr.precise_ip.

perf trace:

  Arnaldo Carvalho de Melo:

  - Add missing %s lost in the 'msg_flags' recvmmsg arg when adding prefix suppression logic.

perf annotate:

  Arnaldo Carvalho de Melo:

  - Calculate the max instruction name, align column to that, removing the
    hardcoded max 6 chars and cope with instructions with names longer than that,
    such as vpmovmskb, vpcmpeqb, etc.

kernel:

  Song Liu:

  - Consider events with attr.bpf_event set as side-band.

  Gustavo A. R. Silva:

  - Mark expected switch fall-through in perf_event_parse_addr_filter().

Libraries:

  Jiri Olsa:

  - Fix leaks and double frees on error paths.

libtraceevent:

  Tony Jones:

  - Fix buffer overflow in arg_eval().

python scripting:

  Tony Jones:

  - More python3 fixes.

Trivial:

  Yang Wei:

  - Remove needless extra semicolon in clang C++ glue code.

Intel PT/BTS:

  Adrian Hunter:

  - Improve auxtrace address filter error message when there is no DSO.

  - Fix divide by zero when TSC is not available.

  - Further improvements to the export to sqlite/posgresql python scripts
    and to the GUI sqlviewer, exporting 'parent_id' so that we have enable
    the creation of call trees.

  Andi Kleen:

  - Generalize function to copy from thread addr space from intel-bts code.

Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parents 43aa378b b8f7d86b

kernel/events/core.c

+2 −1
Original line number Diff line number Diff line
@@ -4238,7 +4238,8 @@ static bool is_sb_event(struct perf_event *event) 
	if (attr->mmap || attr->mmap_data || attr->mmap2 ||

	    attr->comm || attr->comm_exec ||

	    attr->task || attr->ksymbol ||

	    attr->context_switch)

	    attr->context_switch ||

	    attr->bpf_event)

		return true;

	return false;

}

tools/lib/traceevent/event-parse.c

+1 −1
Original line number Diff line number Diff line
@@ -2457,7 +2457,7 @@ static int arg_num_eval(struct tep_print_arg *arg, long long *val) 
static char *arg_eval (struct tep_print_arg *arg)

{

	long long val;

	static char buf[20];

	static char buf[24];



	switch (arg->type) {

	case TEP_PRINT_ATOM:

tools/perf/Documentation/perf-diff.txt

+56 −0
Original line number Diff line number Diff line
@@ -118,6 +118,62 @@ OPTIONS 
	sum of shown entries will be always 100%.  "absolute" means it retains

	the original value before and after the filter is applied.



--time::

	Analyze samples within given time window. It supports time

	percent with multiple time ranges. Time string is 'a%/n,b%/m,...'

	or 'a%-b%,c%-%d,...'.



	For example:



	Select the second 10% time slice to diff:



	  perf diff --time 10%/2



	Select from 0% to 10% time slice to diff:



	  perf diff --time 0%-10%



	Select the first and the second 10% time slices to diff:



	  perf diff --time 10%/1,10%/2



	Select from 0% to 10% and 30% to 40% slices to diff:



	  perf diff --time 0%-10%,30%-40%



	It also supports analyzing samples within a given time window

	<start>,<stop>. Times have the format seconds.microseconds. If 'start'

	is not given (i.e., time string is ',x.y') then analysis starts at

	the beginning of the file. If stop time is not given (i.e, time

	string is 'x.y,') then analysis goes to the end of the file. Time string is

	'a1.b1,c1.d1:a2.b2,c2.d2'. Use ':' to separate timestamps for different

	perf.data files.



	For example, we get the timestamp information from 'perf script'.



	  perf script -i perf.data.old

	    mgen 13940 [000]  3946.361400: ...



	  perf script -i perf.data

	    mgen 13940 [000]  3971.150589 ...



	  perf diff --time 3946.361400,:3971.150589,



	It analyzes the perf.data.old from the timestamp 3946.361400 to

	the end of perf.data.old and analyzes the perf.data from the

	timestamp 3971.150589 to the end of perf.data.



--cpu:: Only diff samples for the list of CPUs provided. Multiple CPUs can

	be provided as a comma-separated list with no space: 0,1. Ranges of

	CPUs are specified with -: 0-2. Default is to report samples on all

	CPUs.



--pid=::

	Only diff samples for given process ID (comma separated list).



--tid=::

	Only diff samples for given thread ID (comma separated list).



COMPARISON

----------

The comparison is governed by the baseline file. The baseline perf.data

tools/perf/arch/arm64/annotate/instructions.c

+1 −1
Original line number Diff line number Diff line
@@ -58,7 +58,7 @@ static int arm64_mov__parse(struct arch *arch __maybe_unused, 
}



static int mov__scnprintf(struct ins *ins, char *bf, size_t size,

			  struct ins_operands *ops);

			  struct ins_operands *ops, int max_ins_name);



static struct ins_ops arm64_mov_ops = {

	.parse	   = arm64_mov__parse,

tools/perf/arch/s390/annotate/instructions.c

+1 −1
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ static int s390_call__parse(struct arch *arch, struct ins_operands *ops, 
}



static int call__scnprintf(struct ins *ins, char *bf, size_t size,

			   struct ins_operands *ops);

			   struct ins_operands *ops, int max_ins_name);



static struct ins_ops s390_call_ops = {

	.parse	   = s390_call__parse,