Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2ddc485 authored by Baolin Wang's avatar Baolin Wang Committed by Alexandre Belloni
Browse files

rtc: sc27xx: Remove interrupts disable and clear in probe() 



When registering one rtc device, it will check to see if there is an
alarm already set in rtc hardware by issuing __rtc_read_alarm(). So
we should not disable the RTC interrupts and clear the interrupts
status in probe() function.

Signed-off-by: default avatarBaolin Wang <baolin.wang@linaro.org>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 7db5adfa

drivers/rtc/rtc-sc27xx.c

+0 −20
Original line number Diff line number Diff line
@@ -129,19 +129,6 @@ static int sprd_rtc_clear_alarm_ints(struct sprd_rtc *rtc) 
			    SPRD_RTC_ALM_INT_MASK);

}



static int sprd_rtc_disable_ints(struct sprd_rtc *rtc)

{

	int ret;



	ret = regmap_update_bits(rtc->regmap, rtc->base + SPRD_RTC_INT_EN,

				 SPRD_RTC_INT_MASK, 0);

	if (ret)

		return ret;



	return regmap_write(rtc->regmap, rtc->base + SPRD_RTC_INT_CLR,

			    SPRD_RTC_INT_MASK);

}



static int sprd_rtc_lock_alarm(struct sprd_rtc *rtc, bool lock)

{

	int ret;
@@ -609,13 +596,6 @@ static int sprd_rtc_probe(struct platform_device *pdev) 
	rtc->dev = &pdev->dev;

	platform_set_drvdata(pdev, rtc);



	/* clear all RTC interrupts and disable all RTC interrupts */

	ret = sprd_rtc_disable_ints(rtc);

	if (ret) {

		dev_err(&pdev->dev, "failed to disable RTC interrupts\n");

		return ret;

	}



	/* check if RTC time values are valid */

	ret = sprd_rtc_check_power_down(rtc);

	if (ret) {