Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b2b93a38 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

slimbus: core: Remove usage of the deprecated ida_simple_xx() API 



[ Upstream commit 89ffa4cccec54467446f141a79b9e36893079fb8 ]

ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

Note that the upper limit of ida_simple_get() is exclusive, but the one of
ida_alloc_range() is inclusive. So change this change allows one more
device. Previously address 0xFE was never used.

Fixes: 46a2bb5a ("slimbus: core: Add slim controllers support")
Cc: Stable@vger.kernel.org
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20240224114137.85781-2-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent aec74a14

drivers/slimbus/core.c

+2 −2
Original line number Diff line number Diff line
@@ -439,8 +439,8 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev, 
		if (ret < 0)

			goto err;

	} else if (report_present) {

		ret = ida_simple_get(&ctrl->laddr_ida,

				     0, SLIM_LA_MANAGER - 1, GFP_KERNEL);

		ret = ida_alloc_max(&ctrl->laddr_ida,

				    SLIM_LA_MANAGER - 1, GFP_KERNEL);

		if (ret < 0)

			goto err;