Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b299362e authored by Eric Biggers's avatar Eric Biggers Committed by Herbert Xu
Browse files

crypto: adiantum - propagate CRYPTO_ALG_ASYNC flag to instance 



If the stream cipher implementation is asynchronous, then the Adiantum
instance must be flagged as asynchronous as well.  Otherwise someone
asking for a synchronous algorithm can get an asynchronous algorithm.

There are no asynchronous xchacha12 or xchacha20 implementations yet
which makes this largely a theoretical issue, but it should be fixed.

Fixes: 059c2a4d ("crypto: adiantum - add Adiantum support")
Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 2fe55987

crypto/adiantum.c

+2 −0
Original line number Diff line number Diff line
@@ -590,6 +590,8 @@ static int adiantum_create(struct crypto_template *tmpl, struct rtattr **tb) 
		     hash_alg->base.cra_driver_name) >= CRYPTO_MAX_ALG_NAME)

		goto out_drop_hash;



	inst->alg.base.cra_flags = streamcipher_alg->base.cra_flags &

				   CRYPTO_ALG_ASYNC;

	inst->alg.base.cra_blocksize = BLOCKCIPHER_BLOCK_SIZE;

	inst->alg.base.cra_ctxsize = sizeof(struct adiantum_tfm_ctx);

	inst->alg.base.cra_alignmask = streamcipher_alg->base.cra_alignmask |