Commit b29330d8 authored Jul 13, 2018 by Alexander Sverdlin Committed by Greg Kroah-Hartman Jul 16, 2018

serial: 8250: of: Correct of_platform_serial_setup() error handling



Don't dispose IRQ mapping before it has been created.

Fixes: aa959474 ("serial: 8250_of: Add IO space support")
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b819e4ab

drivers/tty/serial/8250/8250_of.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -124,7 +124,7 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
	dev_warn(&ofdev->dev, "unsupported reg-io-width (%d)\n",		dev_warn(&ofdev->dev, "unsupported reg-io-width (%d)\n",
	prop);		prop);
	ret = -EINVAL;		ret = -EINVAL;
	goto err_dispose;		goto err_unprepare;
	}		}
	}		}
	port->flags \|= UPF_IOREMAP;		port->flags \|= UPF_IOREMAP;