Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b1c04e80 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Tejun Heo
Browse files

libata: return boolean values from ata_is_* 



This way we don't have to worry about the exact bit postition of the
test to leak out and any crazy propagation effects in the callers.

Suggested-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 2983860c

include/linux/libata.h

+8 −8
Original line number Diff line number Diff line
@@ -1063,32 +1063,32 @@ static inline unsigned int ata_prot_flags(u8 prot) 
	return 0;

}



static inline int ata_is_atapi(u8 prot)

static inline bool ata_is_atapi(u8 prot)

{

	return ata_prot_flags(prot) & ATA_PROT_FLAG_ATAPI;

}



static inline int ata_is_nodata(u8 prot)

static inline bool ata_is_nodata(u8 prot)

{

	return !(ata_prot_flags(prot) & ATA_PROT_FLAG_DATA);

}



static inline int ata_is_pio(u8 prot)

static inline bool ata_is_pio(u8 prot)

{

	return ata_prot_flags(prot) & ATA_PROT_FLAG_PIO;

}



static inline int ata_is_dma(u8 prot)

static inline bool ata_is_dma(u8 prot)

{

	return ata_prot_flags(prot) & ATA_PROT_FLAG_DMA;

}



static inline int ata_is_ncq(u8 prot)

static inline bool ata_is_ncq(u8 prot)

{

	return ata_prot_flags(prot) & ATA_PROT_FLAG_NCQ;

}



static inline int ata_is_data(u8 prot)

static inline bool ata_is_data(u8 prot)

{

	return ata_prot_flags(prot) & ATA_PROT_FLAG_DATA;

}
@@ -1407,7 +1407,7 @@ static inline bool sata_pmp_attached(struct ata_port *ap) 
	return ap->nr_pmp_links != 0;

}



static inline int ata_is_host_link(const struct ata_link *link)

static inline bool ata_is_host_link(const struct ata_link *link)

{

	return link == &link->ap->link || link == link->ap->slave_link;

}
@@ -1422,7 +1422,7 @@ static inline bool sata_pmp_attached(struct ata_port *ap) 
	return false;

}



static inline int ata_is_host_link(const struct ata_link *link)

static inline bool ata_is_host_link(const struct ata_link *link)

{

	return 1;

}