Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b18e606f authored by Enric Balletbo i Serra's avatar Enric Balletbo i Serra
Browse files

platform/chrome: cros_ec_debugfs: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarEnric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent e43c426a

drivers/platform/chrome/cros_ec_debugfs.c

+6 −29
Original line number Diff line number Diff line
@@ -337,12 +337,8 @@ static int cros_ec_create_console_log(struct cros_ec_debugfs *debug_info) 
	mutex_init(&debug_info->log_mutex);

	init_waitqueue_head(&debug_info->log_wq);



	if (!debugfs_create_file("console_log",

				 S_IFREG | 0444,

				 debug_info->dir,

				 debug_info,

				 &cros_ec_console_log_fops))

		return -ENOMEM;

	debugfs_create_file("console_log", S_IFREG | 0444, debug_info->dir,

			    debug_info, &cros_ec_console_log_fops);



	INIT_DELAYED_WORK(&debug_info->log_poll_work,

			  cros_ec_console_log_work);
@@ -390,13 +386,8 @@ static int cros_ec_create_panicinfo(struct cros_ec_debugfs *debug_info) 
	debug_info->panicinfo_blob.data = msg->data;

	debug_info->panicinfo_blob.size = ret;



	if (!debugfs_create_blob("panicinfo",

				 S_IFREG | 0444,

				 debug_info->dir,

				 &debug_info->panicinfo_blob)) {

		ret = -ENOMEM;

		goto free;

	}

	debugfs_create_blob("panicinfo", S_IFREG | 0444, debug_info->dir,

			    &debug_info->panicinfo_blob);



	return 0;
@@ -405,15 +396,6 @@ static int cros_ec_create_panicinfo(struct cros_ec_debugfs *debug_info) 
	return ret;

}



static int cros_ec_create_pdinfo(struct cros_ec_debugfs *debug_info)

{

	if (!debugfs_create_file("pdinfo", 0444, debug_info->dir, debug_info,

				 &cros_ec_pdinfo_fops))

		return -ENOMEM;



	return 0;

}



static int cros_ec_debugfs_probe(struct platform_device *pd)

{

	struct cros_ec_dev *ec = dev_get_drvdata(pd->dev.parent);
@@ -428,8 +410,6 @@ static int cros_ec_debugfs_probe(struct platform_device *pd) 


	debug_info->ec = ec;

	debug_info->dir = debugfs_create_dir(name, NULL);

	if (!debug_info->dir)

		return -ENOMEM;



	ret = cros_ec_create_panicinfo(debug_info);

	if (ret)
@@ -439,9 +419,8 @@ static int cros_ec_debugfs_probe(struct platform_device *pd) 
	if (ret)

		goto remove_debugfs;



	ret = cros_ec_create_pdinfo(debug_info);

	if (ret)

		goto remove_log;

	debugfs_create_file("pdinfo", 0444, debug_info->dir, debug_info,

			    &cros_ec_pdinfo_fops);



	ec->debug_info = debug_info;
@@ -449,8 +428,6 @@ static int cros_ec_debugfs_probe(struct platform_device *pd) 


	return 0;



remove_log:

	cros_ec_cleanup_console_log(debug_info);

remove_debugfs:

	debugfs_remove_recursive(debug_info->dir);

	return ret;