Commit b18bcb00 authored Aug 08, 2016 by Liping Zhang Committed by Pablo Neira Ayuso Aug 09, 2016

netfilter: nfnetlink_queue: fix memory leak when attach expectation successfully



User can use NFQA_EXP to attach expectations to conntracks, but we
forget to put back nf_conntrack_expect when it is inserted successfully,
i.e. in this normal case, expect's use refcnt will be 3. So even we
unlink it and put it back later, the use refcnt is still 1, then the
memory will be leaked forever.

Signed-off-by: Liping Zhang <liping.zhang@spreadtrum.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent b173a28f

net/netfilter/nf_conntrack_netlink.c

+2 −6

Original line number	Diff line number	Diff line
		@@ -2362,14 +2362,10 @@ ctnetlink_glue_attach_expect(const struct nlattr attr, struct nf_conn ct,
		return PTR_ERR(exp);

		err = nf_ct_expect_related_report(exp, portid, report);
		if (err < 0) {
		nf_ct_expect_put(exp);
		return err;
		}

		return 0;
		}

		static void ctnetlink_glue_seqadj(struct sk_buff skb, struct nf_conn ct,
		enum ip_conntrack_info ctinfo, int diff)
		{