Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b163098e authored by Mitch Williams's avatar Mitch Williams Committed by Jeff Kirsher
Browse files

i40evf: Allocate Rx buffers properly



Allocate the correct number of RX buffers, and don't fiddle with
next_to_use. The common RX code handles all of this. This fixes a memory
leak of one page each time the driver is opened.

Change-Id: Id06eca353086e084921f047acad28c14745684ee
Signed-off-by: default avatarMitch Williams <mitch.a.williams@intel.com>
Tested-by: default avatarAndrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent bec60fc4
Loading
Loading
Loading
Loading
+1 −4
Original line number Diff line number Diff line
@@ -990,9 +990,7 @@ static void i40evf_configure(struct i40evf_adapter *adapter)
	for (i = 0; i < adapter->num_active_queues; i++) {
		struct i40e_ring *ring = &adapter->rx_rings[i];

		i40evf_alloc_rx_buffers(ring, ring->count);
		ring->next_to_use = ring->count - 1;
		writel(ring->next_to_use, ring->tail);
		i40evf_alloc_rx_buffers(ring, I40E_DESC_UNUSED(ring));
	}
}

@@ -2768,7 +2766,6 @@ static void i40evf_remove(struct pci_dev *pdev)

	iounmap(hw->hw_addr);
	pci_release_regions(pdev);

	i40evf_free_all_tx_resources(adapter);
	i40evf_free_all_rx_resources(adapter);
	i40evf_free_queues(adapter);