Commit b1622cb3 authored Jun 10, 2019 by Tomi Valkeinen Committed by Andrzej Hajda Jun 14, 2019

drm/bridge: tfp410: fix use of cancel_delayed_work_sync



We use delayed_work in HPD handling, and cancel any scheduled work in
tfp410_fini using cancel_delayed_work_sync(). However, we have only
initialized the delayed work if we actually have a HPD interrupt
configured in the DT, but in the tfp410_fini, we always cancel the work,
possibly causing a WARN().

Fix this by doing the cancel only if we actually had the delayed work
set up.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190610135739.6077-2-tomi.valkeinen@ti.com

parent c08f99c3

drivers/gpu/drm/bridge/ti-tfp410.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -381,6 +381,7 @@ static int tfp410_fini(struct device *dev)
		{
		struct tfp410 *dvi = dev_get_drvdata(dev);

		if (dvi->hpd_irq >= 0)
		cancel_delayed_work_sync(&dvi->hpd_work);

		drm_bridge_remove(&dvi->bridge);