Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b0e5168a authored Jun 20, 2019 by Chaitanya Kulkarni Committed by Jens Axboe Jun 20, 2019

block: update print_req_error()



Improve the print_req_error with additional request fields which are
helpful for debugging. Use newly introduced blk_op_str() to print the
REQ_OP_XXX in the string format.

Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 874c893b

block/blk-core.c

+7 −4

Original line number	Diff line number	Diff line
		@@ -212,11 +212,14 @@ static void print_req_error(struct request *req, blk_status_t status,
		return;

		printk_ratelimited(KERN_ERR
		"%s: %s error, dev %s, sector %llu op 0x%x flags 0x%x\n",
		"%s: %s error, dev %s, sector %llu op 0x%x:(%s) flags 0x%x "
		"phys_seg %u prio class %u\n",
		caller, blk_errors[idx].name,
		req->rq_disk ? req->rq_disk->disk_name : "?",
		blk_rq_pos(req), req_op(req),
		req->cmd_flags & ~REQ_OP_MASK);
		blk_rq_pos(req), req_op(req), blk_op_str(req_op(req)),
		req->cmd_flags & ~REQ_OP_MASK,
		req->nr_phys_segments,
		IOPRIO_PRIO_CLASS(req->ioprio));
		}

		static void req_bio_endio(struct request rq, struct bio bio,