Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b0a42f2a authored by Steve French's avatar Steve French
Browse files

smb3: add missing read completion trace point 



When ENODATA returned we weren't logging the read completion
(not an error, but can be indicated by logging length 0) which
makes looking at read traces confusing for smb3.

Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
Reviewed-by: default avatarRonnie Sahlberg <lsahlber@redhat.com>
parent d323c246

fs/cifs/smb2pdu.c

+4 −1
Original line number Original line Diff line number Diff line
@@ -3404,7 +3404,10 @@ SMB2_read(const unsigned int xid, struct cifs_io_parms *io_parms, 
					    io_parms->tcon->tid, ses->Suid,

					    io_parms->tcon->tid, ses->Suid,

					    io_parms->offset, io_parms->length,

					    io_parms->offset, io_parms->length,

					    rc);

					    rc);

		}

		} else

			trace_smb3_read_done(xid, req->PersistentFileId,

				    io_parms->tcon->tid, ses->Suid,

				    io_parms->offset, 0);

		free_rsp_buf(resp_buftype, rsp_iov.iov_base);

		free_rsp_buf(resp_buftype, rsp_iov.iov_base);

		return rc == -ENODATA ? 0 : rc;

		return rc == -ENODATA ? 0 : rc;

	} else

	} else