Commit b09de7fa authored Apr 30, 2012 by Theodore Ts'o

ext4: remove unnecessary check in add_dirent_to_buf()

None of this function callers ever pass in a NULL inode pointer, so
this check is unnecessary, and the else clause is dead code. (This
change should make the code coverage people a little happier. :-)

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

parent 5c359a47

fs/ext4/namei.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -1612,11 +1612,8 @@ static int add_dirent_to_buf(handle_t handle, struct dentry dentry,
		de = de1;
		}
		de->file_type = EXT4_FT_UNKNOWN;
		if (inode) {
		de->inode = cpu_to_le32(inode->i_ino);
		ext4_set_de_type(dir->i_sb, de, inode->i_mode);
		} else
		de->inode = 0;
		de->name_len = namelen;
		memcpy(de->name, name, namelen);
		/*