Commit b062fb0c authored Dec 20, 2019 by Malcolm Priestley Committed by Greg Kroah-Hartman Jan 14, 2020

staging: vt6656: Fix non zero logical return of, usb_control_msg



commit 58c3e681b04dd57c70d0dcb7b69fe52d043ff75a upstream.

Starting with commit 59608cb1
("staging: vt6656: clean function's error path in usbpipe.c")
the usb control functions have returned errors throughout driver
with only logical variable checking.

However, usb_control_msg return the amount of bytes transferred
this means that normal operation causes errors.

Correct the return function so only return zero when transfer
is successful.

Cc: stable <stable@vger.kernel.org> # v5.3+
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Link: https://lore.kernel.org/r/08e88842-6f78-a2e3-a7a0-139fec960b2b@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f2a6955c

drivers/staging/vt6656/usbpipe.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -59,7 +59,9 @@ int vnt_control_out(struct vnt_private *priv, u8 request, u16 value,

		kfree(usb_buffer);

		if (ret >= 0 && ret < (int)length)
		if (ret == (int)length)
		ret = 0;
		else
		ret = -EIO;

		end_unlock:
		@@ -103,7 +105,9 @@ int vnt_control_in(struct vnt_private *priv, u8 request, u16 value,

		kfree(usb_buffer);

		if (ret >= 0 && ret < (int)length)
		if (ret == (int)length)
		ret = 0;
		else
		ret = -EIO;

		end_unlock: