Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b061b28b authored by Alex Bee's avatar Alex Bee Committed by Sasha Levin
Browse files

drm/rockchip: inno_hdmi: Fix video timing 

[ Upstream commit 47a145c03484d33e65d773169d5ca1b9fe2a492e ]

The controller wants the difference between *total and *sync_start in the
HDMI_VIDEO_EXT_*DELAY registers. Otherwise the signal is very unstable for
certain non-VIC modes. See downstream commit [0].

[0] https://github.com/rockchip-linux/kernel/commit/8eb559f2502c



Fixes: 412d4ae6 ("drm/rockchip: hdmi: add Innosilicon HDMI support")
Co-developed-by: default avatarZheng Yang <zhengyang@rock-chips.com>
Signed-off-by: default avatarZheng Yang <zhengyang@rock-chips.com>
Signed-off-by: default avatarAlex Bee <knaerzche@gmail.com>
Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231222174220.55249-4-knaerzche@gmail.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 91dc47cd

drivers/gpu/drm/rockchip/inno_hdmi.c

+2 −2
Original line number Diff line number Diff line
@@ -401,7 +401,7 @@ static int inno_hdmi_config_video_timing(struct inno_hdmi *hdmi, 
	hdmi_writeb(hdmi, HDMI_VIDEO_EXT_HBLANK_L, value & 0xFF);

	hdmi_writeb(hdmi, HDMI_VIDEO_EXT_HBLANK_H, (value >> 8) & 0xFF);



	value = mode->hsync_start - mode->hdisplay;

	value = mode->htotal - mode->hsync_start;

	hdmi_writeb(hdmi, HDMI_VIDEO_EXT_HDELAY_L, value & 0xFF);

	hdmi_writeb(hdmi, HDMI_VIDEO_EXT_HDELAY_H, (value >> 8) & 0xFF);
@@ -416,7 +416,7 @@ static int inno_hdmi_config_video_timing(struct inno_hdmi *hdmi, 
	value = mode->vtotal - mode->vdisplay;

	hdmi_writeb(hdmi, HDMI_VIDEO_EXT_VBLANK, value & 0xFF);



	value = mode->vsync_start - mode->vdisplay;

	value = mode->vtotal - mode->vsync_start;

	hdmi_writeb(hdmi, HDMI_VIDEO_EXT_VDELAY, value & 0xFF);



	value = mode->vsync_end - mode->vsync_start;