Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b05232d6 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding
Browse files

pwm: samsung: Don't uses devm_*() functions in ->request() 



A call to ->request() is always paired by a call to ->free() before a
given device is disposed. So the simplification that usually is possible
when using devm_*() functions cannot be used here. So use plain
kzalloc() and kfree() for improved runtime behaviour and reduced memory
footprint.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
[thierry.reding@gmail.com: fix build failure]
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent e926b12c

drivers/pwm/pwm-samsung.c

+2 −2
Original line number Diff line number Diff line
@@ -226,7 +226,7 @@ static int pwm_samsung_request(struct pwm_chip *chip, struct pwm_device *pwm) 
		return -EINVAL;

	}



	our_chan = devm_kzalloc(chip->dev, sizeof(*our_chan), GFP_KERNEL);

	our_chan = kzalloc(sizeof(*our_chan), GFP_KERNEL);

	if (!our_chan)

		return -ENOMEM;
@@ -237,7 +237,7 @@ static int pwm_samsung_request(struct pwm_chip *chip, struct pwm_device *pwm) 


static void pwm_samsung_free(struct pwm_chip *chip, struct pwm_device *pwm)

{

	devm_kfree(chip->dev, pwm_get_chip_data(pwm));

	kfree(pwm_get_chip_data(pwm));

}



static int pwm_samsung_enable(struct pwm_chip *chip, struct pwm_device *pwm)