Commit afffe0d1 authored Apr 07, 2023 by Denis Plotnikov Committed by Greg Kroah-Hartman Apr 20, 2023

qlcnic: check pci_reset_function result



[ Upstream commit 7573099e10ca69c3be33995c1fcd0d241226816d ]

Static code analyzer complains to unchecked return value.
The result of pci_reset_function() is unchecked.
Despite, the issue is on the FLR supported code path and in that
case reset can be done with pcie_flr(), the patch uses less invasive
approach by adding the result check of pci_reset_function().

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 7e2cf4fe ("qlcnic: change driver hardware interface mechanism")
Signed-off-by: Denis Plotnikov <den-plotnikov@yandex-team.ru>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent a841f6a0

drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -629,7 +629,13 @@ int qlcnic_fw_create_ctx(struct qlcnic_adapter *dev)
		int i, err, ring;

		if (dev->flags & QLCNIC_NEED_FLR) {
		pci_reset_function(dev->pdev);
		err = pci_reset_function(dev->pdev);
		if (err) {
		dev_err(&dev->pdev->dev,
		"Adapter reset failed (%d). Please reboot\n",
		err);
		return err;
		}
		dev->flags &= ~QLCNIC_NEED_FLR;
		}