Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit affada72 authored Apr 18, 2019 by Borislav Petkov Committed by Greg Kroah-Hartman Apr 25, 2019

driver core: Clarify which counterparts to use to device_add()



It is not absolutely clear from the docs how the cleanup path after
device_add() should look like so spell it out explicitly.

No functional changes, just documentation.

Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9abb2499

drivers/base/core.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1999,6 +1999,11 @@ static int device_private_init(struct device *dev)
		* NOTE: _Never_ directly free @dev after calling this function, even
		* if it returned an error! Always use put_device() to give up your
		* reference instead.
		*
		* Rule of thumb is: if device_add() succeeds, you should call
		* device_del() when you want to get rid of it. If device_add() has
		* not succeeded, use only put_device() to drop the reference
		* count.
		*/
		int device_add(struct device *dev)
		{