Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit afe3840a authored by Andrei Emeltchenko's avatar Andrei Emeltchenko Committed by John W. Linville
Browse files

mwifiex: Using %*phD instead of print_hex_dump_bytes 



Make output more readable and remove unneeded function call.

...
mwifiex_sdio mmc0:0001:1: last_cmd_index = 3
last_cmd_id: 00000000: 16 00 cd 00 83 00 df 00 28 00 ........(.
...

would be changed to:

...
mwifiex_sdio mmc0:0001:1: last_cmd_index = 3
mwifiex_sdio mmc1:0001:1: last_cmd_id: 16 00 cd 00 83 00 df 00 28 00
...

Signed-off-by: default avatarAndrei Emeltchenko <andrei.emeltchenko@intel.com>
Signed-off-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent f575f658

drivers/net/wireless/mwifiex/cmdevt.c

+12 −12
Original line number Diff line number Diff line
@@ -917,24 +917,24 @@ mwifiex_cmd_timeout_func(unsigned long function_context) 


		dev_err(adapter->dev, "last_cmd_index = %d\n",

			adapter->dbg.last_cmd_index);

		print_hex_dump_bytes("last_cmd_id: ", DUMP_PREFIX_OFFSET,

				     adapter->dbg.last_cmd_id,

				     sizeof(adapter->dbg.last_cmd_id));

		print_hex_dump_bytes("last_cmd_act: ", DUMP_PREFIX_OFFSET,

				     adapter->dbg.last_cmd_act,

				     sizeof(adapter->dbg.last_cmd_act));

		dev_err(adapter->dev, "last_cmd_id: %*ph\n",

			(int)sizeof(adapter->dbg.last_cmd_id),

			adapter->dbg.last_cmd_id);

		dev_err(adapter->dev, "last_cmd_act: %*ph\n",

			(int)sizeof(adapter->dbg.last_cmd_act),

			adapter->dbg.last_cmd_act);



		dev_err(adapter->dev, "last_cmd_resp_index = %d\n",

			adapter->dbg.last_cmd_resp_index);

		print_hex_dump_bytes("last_cmd_resp_id: ", DUMP_PREFIX_OFFSET,

				     adapter->dbg.last_cmd_resp_id,

				     sizeof(adapter->dbg.last_cmd_resp_id));

		dev_err(adapter->dev, "last_cmd_resp_id: %*ph\n",

			(int)sizeof(adapter->dbg.last_cmd_resp_id),

			adapter->dbg.last_cmd_resp_id);



		dev_err(adapter->dev, "last_event_index = %d\n",

			adapter->dbg.last_event_index);

		print_hex_dump_bytes("last_event: ", DUMP_PREFIX_OFFSET,

				     adapter->dbg.last_event,

				     sizeof(adapter->dbg.last_event));

		dev_err(adapter->dev, "last_event: %*ph\n",

			(int)sizeof(adapter->dbg.last_event),

			adapter->dbg.last_event);



		dev_err(adapter->dev, "data_sent=%d cmd_sent=%d\n",

			adapter->data_sent, adapter->cmd_sent);