Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit afb33e40 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva
Browse files

ASN.1: mark expected switch fall-through 



In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warnings:

lib/asn1_decoder.c:386:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
lib/asn1_decoder.c:449:6: warning: this statement may fall through [-Wimplicit-fallthrough=]

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enabling
-Wimplicit-fallthrough.

Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
parent 8a05452c

lib/asn1_decoder.c

+4 −0
Original line number Diff line number Diff line
@@ -385,6 +385,8 @@ int asn1_ber_decoder(const struct asn1_decoder *decoder, 
	case ASN1_OP_END_SET_ACT:

		if (unlikely(!(flags & FLAG_MATCHED)))

			goto tag_mismatch;

		/* fall through */



	case ASN1_OP_END_SEQ:

	case ASN1_OP_END_SET_OF:

	case ASN1_OP_END_SEQ_OF:
@@ -450,6 +452,8 @@ int asn1_ber_decoder(const struct asn1_decoder *decoder, 
			pc += asn1_op_lengths[op];

			goto next_op;

		}

		/* fall through */



	case ASN1_OP_ACT:

		ret = actions[machine[pc + 1]](context, hdr, tag, data + tdp, len);

		if (ret < 0)