Commit af96f0d6 authored Nov 14, 2016 by Tetsuo Handa Committed by Casey Schaufler Apr 04, 2017

Smack: Use GFP_KERNEL for smk_netlbl_mls().



Since all callers of smk_netlbl_mls() are GFP_KERNEL context
(smk_set_cipso() calls memdup_user_nul(), init_smk_fs() calls
__kernfs_new_node(), smk_import_entry() calls kzalloc(GFP_KERNEL)),
it is safe to use GFP_KERNEL from netlbl_catmap_setbit().

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>

parent c3c8dc9f

security/smack/smack_access.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -504,7 +504,7 @@ int smk_netlbl_mls(int level, char catset, struct netlbl_lsm_secattr sap,
		if ((m & *cp) == 0)
		continue;
		rc = netlbl_catmap_setbit(&sap->attr.mls.cat,
		cat, GFP_ATOMIC);
		cat, GFP_KERNEL);
		if (rc < 0) {
		netlbl_catmap_free(sap->attr.mls.cat);
		return rc;