Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit af505208 authored by Lukas Wunner's avatar Lukas Wunner Committed by Mark Brown
Browse files

spi: bcm2835: Drop assignment of dma_slave_config direction 



The BCM2835 SPI driver still sets the "direction" member in struct
dma_slave_config even though it was deprecated five years ago with
commit d9ff958b ("dmaengine: Mark the struct dma_slave_config
direction field deprecated") and is no longer evaluated by the BCM2835
DMA driver since commit 00648f4d ("dmaengine: bcm2835: remove
dma_slave_config direction usage").

Drop the superfluous assignment.
No functional change intended.

Signed-off-by: default avatarLukas Wunner <lukas@wunner.de>
Cc: Frank Pavlic <f.pavlic@kunbus.de>
Cc: Martin Sperl <kernel@martin.sperl.org>
Cc: Noralf Trønnes <noralf@tronnes.org>
Reviewed-by: default avatarVinod Koul <vkoul@kernel.org>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5f336ea5

drivers/spi/spi-bcm2835.c

+0 −2
Original line number Diff line number Diff line
@@ -729,7 +729,6 @@ static void bcm2835_dma_init(struct spi_controller *ctlr, struct device *dev) 
	}



	/* configure DMAs */

	slave_config.direction = DMA_MEM_TO_DEV;

	slave_config.dst_addr = (u32)(dma_reg_base + BCM2835_SPI_FIFO);

	slave_config.dst_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
@@ -737,7 +736,6 @@ static void bcm2835_dma_init(struct spi_controller *ctlr, struct device *dev) 
	if (ret)

		goto err_config;



	slave_config.direction = DMA_DEV_TO_MEM;

	slave_config.src_addr = (u32)(dma_reg_base + BCM2835_SPI_FIFO);

	slave_config.src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;