Commit af4be8e1 authored Jul 04, 2021 by Maulik Shah Committed by Gerrit - the friendly Code Review server Jul 26, 2021

drivers: rpmh: Always bug_on() upon timeout in rpmh_write_batch()



rpmh_rsc_debug() can race with tcs_tx_done() interrupt handler and
may not see any tcs busy and hence won't do bug_on(). Later it may
go ahead and free() the request which interrupt handler is processing.

Lets always bug_on() upon timeout.

Change-Id: I238a6a3639077850df158cb1f0190656e014bb57
Signed-off-by: Maulik Shah <mkshah@codeaurora.org>

parent d915a465

drivers/soc/qcom/rpmh.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -485,8 +485,7 @@ int rpmh_write_batch(const struct device *dev, enum rpmh_state state,
		* we've returned from this function.
		*/
		rpmh_rsc_debug(ctrlr_to_drv(ctrlr), &compls[i]);
		ret = -ETIMEDOUT;
		goto exit;
		BUG_ON(1);
		}
		}