Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae6017a7 authored by Huazhong Tan's avatar Huazhong Tan Committed by David S. Miller
Browse files

net: hns3: fix incomplete uninitialization of IRQ in the hns3_nic_uninit_vector_data() 



In the hns3_nic_uninit_vector_data(), the procedure of uninitializing
the tqp_vector's IRQ has not set affinity_notify to NULL and changes
its init flag. This patch fixes it. And for simplificaton, local
variable tqp_vector is used instead of priv->tqp_vector[i].

Fixes: 424eb834 ("net: hns3: Unified HNS3 {VF|PF} Ethernet Driver for hip08 SoC")
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b51c366d

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+6 −6
Original line number Diff line number Diff line
@@ -3181,12 +3181,12 @@ static int hns3_nic_uninit_vector_data(struct hns3_nic_priv *priv) 


		hns3_free_vector_ring_chain(tqp_vector, &vector_ring_chain);



		if (priv->tqp_vector[i].irq_init_flag == HNS3_VECTOR_INITED) {

			(void)irq_set_affinity_hint(

				priv->tqp_vector[i].vector_irq,

		if (tqp_vector->irq_init_flag == HNS3_VECTOR_INITED) {

			irq_set_affinity_notifier(tqp_vector->vector_irq,

						  NULL);

			free_irq(priv->tqp_vector[i].vector_irq,

				 &priv->tqp_vector[i]);

			irq_set_affinity_hint(tqp_vector->vector_irq, NULL);

			free_irq(tqp_vector->vector_irq, tqp_vector);

			tqp_vector->irq_init_flag = HNS3_VECTOR_NOT_INITED;

		}



		priv->ring_data[i].ring->irq_init_flag = HNS3_VECTOR_NOT_INITED;